Skip to content

feat: Add KUBERNETES_NODE_NAME env var to operator Pods #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 9, 2025
@sbernauer sbernauer self-assigned this Jul 9, 2025
razvan
razvan previously approved these changes Jul 9, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a small comment explaining why it's needed.

@sbernauer
Copy link
Member Author

I added a small explanation what the env vars are and how to find about the meaning in 52047c1
I would like to avoid doubling information, does that work for you?

@sbernauer sbernauer requested a review from razvan July 9, 2025 10:15
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 9, 2025
@sbernauer sbernauer requested a review from razvan July 9, 2025 10:52
@sbernauer
Copy link
Member Author

Thanks for the quick review!

@sbernauer sbernauer added this pull request to the merge queue Jul 9, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 9, 2025
Merged via the queue into main with commit d19ad96 Jul 9, 2025
2 checks passed
@sbernauer sbernauer deleted the feat/k8s-node-name branch July 9, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants